search

tlh / workgroups.el

workgroups for windows -- sexy window management for emacs
242 stars 30 forks source link

Faces are illegible on light displays #12

Closed purcell closed 13 years ago

purcell commented 13 years ago

The current face defs specify light-colored :foregrounds on color displays, but these are illegible when using a theme with a light background.

One solution would be to add the background class specifier to the faces so that those light foreground colors would only be applied when the display has a dark background.

A better and more general solution, and one which I would strongly advise, would be to follow the pattern of many other emacs packages (including org), and use :inherit to derive your faces from a variety of built-in faces, e.g. font-lock-keyword-face. This way, the workgroups faces will look okay by default with any theme, but can still be overridden if desired.

Keep up the great work!

Cheers,

-Steve

tlh commented 13 years ago

Hey there -- thanks. This has been fixed in the upcoming 1.0.0 release (all faces have been redefined to inherit from font-lock-foo faces), I just haven't gotten around to updating the master branch.

purcell commented 13 years ago

Great - I didn't spot that!

dabrahams commented 12 years ago

Is that in the "experimental" branch? When do you plan to release it? Thanks!