tlienart / Franklin.jl

(yet another) static site generator. Simple, customisable, fast, maths with KaTeX, code evaluation, optional pre-rendering, in Julia.
https://franklinjl.org
MIT License
952 stars 112 forks source link

[windows] Lunr function might fail on windows #553

Open tlienart opened 4 years ago

tlienart commented 4 years ago

A user reported that the index builds with the __site in the URLs specifically instead of :

"6":{"t":"lorem ipsum","l":"/../pages/howTo/setInversion/index.html"},"7":{"t":"lorem ipsum","l":"/../pages/lorem_ipsum/index.html"},

they get

"5":{"t":"lorem ipsum","l":"..\\..\\__site\\pages\\howTo\\index.html"},"6":{"t":"lorem ipsum","l":"..\\..\\__site\\pages\\howTo\\setInversion\\index.html"},"7":{"t":"lorem ipsum","l":"..\\..\\__site\\pages\\lorem_ipsum\\index.html"},

this is probably easy to fix and might just be an issue with the index builder

tlienart commented 4 years ago
replace(/\\/g,'\/').

in build_index.js, that's because path.join uses windows separator on windows 🙄

tlienart commented 4 years ago

Todo: need to check that FranklinTemplates has the fix