search

tlienart / FranklinTemplates.jl

Simple website templates for Franklin.jl
https://tlienart.github.io/FranklinTemplates.jl/
MIT License
76 stars 24 forks source link

Use stylesheet for rss #147

Closed kdheepak closed 2 years ago

tlienart commented 2 years ago

thanks for this, I'll have a look to see if it seems to work fine

tlienart commented 2 years ago

hmm the path is not going to be correct

kdheepak commented 2 years ago

Feel free to fix this if you need to I’m not going to get to my computer until Sunday I imagine.

tlienart commented 2 years ago

I'm actually going to revert this, it looks like the XSL file is incorrect and I don't know how to fix it nor do I really have the time to invest in this.

Thanks for taking the time to look into it, we can probably do this some other time with more testing.

kdheepak commented 2 years ago

Sure, sorry for the rushed PR on my end too. Next time I’ll test it and make sure everything works.

tlienart commented 2 years ago

np, RSS is a very weird world with lots of bad specs, no docs, and seemingly no standard. Probably because very few people still use it. I think as long as most Franklin websites are able to generate a valid RSS sheet it's probably fine, the styling was nice but most browsers (apart from FF) would fire up the local RSS reader anyway so this would have been a minor change. I'm glad we gave it a shot though