tlienart / FranklinTemplates.jl

Simple website templates for Franklin.jl
https://tlienart.github.io/FranklinTemplates.jl/
MIT License
76 stars 24 forks source link

[Bug] CSS is broken on the tags pages #154

Open onnyyonn opened 2 years ago

onnyyonn commented 2 years ago

The tag pages don't inherit the styles properly.

For example https://tlienart.github.io/FranklinTemplates.jl/templates/hyde/tag/syntax/

Suggested fix: Change the line from <div class="{{div_content}}"> to <div class="franklin-content"> in _layout/tag.html.

tlienart commented 2 years ago

thanks for reporting, {{div_content}} by default inserts franklin-content so I need to investigate why that wasn't the case for you.

Would you mind pointing me to a commit before you applied your resolving fix so I can experiment with hit?

onnyyonn commented 2 years ago

Thanks for your response. I don't have a commit to point you to yet, because I was trying it locally. But if needed, I can create a dummy repo.

But I am wondering, are they working as expected in your own repo? For example https://tlienart.github.io/FranklinTemplates.jl/templates/hyde/tag/syntax/ . I am seeing this page broken, as shown in the screenshot.

Screenshot_20220531_043550

tlienart commented 2 years ago

Thanks, actually that link was all I needed to look at, I should have looked at your first comment properly.

So here the problem is that the {{div_content}} is not properly filled, I'll look into it. Thanks (and indeed now your fix makes sense).