tlienart / FranklinTemplates.jl

Simple website templates for Franklin.jl
https://tlienart.github.io/FranklinTemplates.jl/
MIT License
76 stars 24 forks source link

add bootstrap5 #164

Closed otwn closed 1 year ago

otwn commented 1 year ago

using CDN version of bootstrap5, bootstrap icon, and FontAwesome 6.

tlienart commented 1 year ago

That's awesome!! tried locally and it's great; thanks a lot for this

two very small changes before merging this:

  1. could you bump up the version to 0.10 so we can release this?
  2. could you remove Franklin in the deps? technically Franklin is not a dep of FranklinTemplates (not that it matters a ton but it avoids circular stuff when doing dev work)

🙌

otwn commented 1 year ago

I hope this works. Thanks

tlienart commented 1 year ago

Thanks a lot!