tlienart / PkgPage.jl

Create a beautiful landing page for your package in less than 10 minutes.

https://tlienart.github.io/PkgPage.jl/

MIT License

116 stars 6 forks source link

Filling config.md automatically #14

Closed Wikunia closed 4 years ago

Wikunia commented 4 years ago

Idea for #11

Currently just parses {{ [a-z_]+ }} in the config.md with a regular expression. If something fails it just copies the config as it is with {{ }} which is probably ugly and I think should never happen. If reading Project.toml or git fails then the same default is used as before.

For me it was just a try to try out Val in dispatch a bit more. Hopefully it is not too ugly.

codecov-commenter commented 4 years ago

Codecov Report

Merging #14 into master will decrease coverage by 12.32%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage   47.61%   35.29%   -12.33%     
===========================================
  Files           5        5               
  Lines         126      170       +44     
===========================================
  Hits           60       60               
- Misses         66      110       +44

Impacted Files	Coverage Δ
src/PkgPage.jl	`100.00% <ø> (ø)`
src/instantiate.jl	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8856b4e...0f2b069. Read the comment docs.

tlienart commented 4 years ago

This is pretty cool

tlienart commented 4 years ago

So this PR was really cool but I think following a suggestion by Zlatan, we will avoid duplication of source files to make the package easier to maintain and this makes the config trick not relevant anymore. I'll close this for now but might come back to it later, sorry about that and thanks for the attempt!!

zlatanvasovic commented 4 years ago

This probably can be incorporated into newpage(), just in a reduced form, with less parameters needed.

tlienart commented 4 years ago

yeah that's what I'm trying to do

Wikunia commented 4 years ago

Would you mind to roughly sketch the new idea for me? :smile:

tlienart commented 4 years ago

there's a rough sketch in https://github.com/tlienart/PkgPage.jl/issues/11#issuecomment-644000429 let me know over there if you have qs :)