tlienart / ft-academic-resume

draft Franklin template for the academic template
10 stars 6 forks source link

Lines connecting multiple "experience" blocks #6

Closed kescobo closed 2 years ago

kescobo commented 2 years ago

franklin:

image

academic:

image

I guess it would require some kind of logic to figure out if it's the last item or not?

tlienart commented 2 years ago

nice yes, the logic for this is https://github.com/tlienart/ft-academic-resume/blob/74b0c6b996e7b35761edfb46ef10167dbe189827/utils.jl#L117-L163 I'm going to read through it now to see if I spot anything but might not have a lot of time (baby about to wake up 😅 ; so just in case I don't answer further that's where we have to look into to figure this out. Shouldn't be very hard though maybe a bit finicky

oh and could you show the code you used for the screenshot? did you specify the first or the active argument?

kescobo commented 2 years ago

oh and could you show the code you used for the screenshot? did you specify the first or the active argument?

Here - I used active=true

kescobo commented 2 years ago

So it looks like the easiest thing would be to add a last argument, then it's something like

if first && last
    line = vspace * pill * vspace
elseif first
    line = vspace * pill * vbar
elseif last
    line = vbar * pill * vspace
else
    line = vbar * pill * vbar
end

There may be some more concise logic...

kescobo commented 2 years ago

This works:

https://github.com/kescobo/FranklinAcademic/blob/main/utils.jl#L117-L157

EDIT: this is outdated - was originally pointing here

kescobo commented 2 years ago

Oh, actually this is much nicer:

    line = pill
    line *= last ? vspace : vbar
    line = (first ? vspace : vbar) * line    
kescobo commented 2 years ago

Even cleaner now https://github.com/kescobo/FranklinAcademic/blob/main/utils.jl#L144