tlienart / thox

[done] phd thesis @ oxford stats
0 stars 0 forks source link

Corrections #22

Closed tlienart closed 6 years ago

tlienart commented 6 years ago

General (need follow up)

RT (can follow up)

fixes from RT to follow up on

Smaller (no need follow up)

PDMP

Consistency fix

final

tlienart commented 6 years ago

Modifications in chap 2

~In 2.3 provide a picture to explain the bouncy PS and provide a more detailed description of the hyperparams of the algorithm~

~Define consistency clearly (p12 importance sampling, p21 integral)~

tlienart commented 6 years ago

Modifications in chap 3

~clarify consistency statement + add reference to consistency of SMC (smoother)~

~better justification of experimental setting~ (RT) ~p37 graphs for things. probably goes with description of setup, p40 same, comment on reasoning for data/methods for chap 1 (see p41)~

tlienart commented 6 years ago

Modifications in chap 4

~better justification of the experimental settings + caveats of HMC setup + discussion of preprocessing~ (RT) ~p45 (naive gibbs + footnote)~~ p48, 49, 50, 51 comments~

tlienart commented 6 years ago

Modifications in chap 5

(RT) ~p64 notation~, ~p71 comment~

Modifications in chap 6

(G) experimental setting; ~consistency p +- 73 "consistent messages"~ ~(G) clarify contribution vs published paper~ ~(G) fix notation d/k in figures~ (RT) ~p75 check comment (normalisation?)~ ~p78 algo check~ ~p82, say a little about where comes from~ ~p83, revisit + add inner reference~ ~p85 MSE etc~ ~p86 more about Bregman~ ~p87, help reader + maybe discuss what these experiments entail (basically say that wanted to show on a simple model can do better than a more complex framework and it's dubious .. )~

tlienart commented 6 years ago

Modifications in chap 7

(G) Consistency fix p ~95 "does not lead to consistent estimators of LBP"

p ~97 "consistent estimators of LBP messages", p ~105 (EPBP) p ~111 "consistent estimators of LBP messages"

(G) ~Better justification of experimental setting~

(G) in chap 7, alg 13, check notations for indexing the nodes

(G) in chap 7, ~define the target for EP~ and ~provide a figure to illustrate the node update in alg13~

(RT) ~general fixes~ ~p92, explain what goes wrong if conditions don't hold~

~p97, helpful...~, ~p98 justify + small fixes~ ~p99 come back~ ~p100 come back~ p101-109 come back (EPBP experiments)

Modifications in ccl

(RT) (in conclusion) ~discuss metrics (see p111, 112 rt), basically you can use log lik (so?)~

tlienart commented 6 years ago

fa8acd0 first finished pass, need to check cosmetics, write short report and done.

tlienart commented 6 years ago

35f2c78