search

tliron / glsp

Language Server Protocol SDK for Go
Apache License 2.0
165 stars 22 forks source link

Implement protocol 3.17.0 #10

Open grouville opened 2 years ago

grouville commented 2 years ago

Hello, First of all, thanks for the library.

It is very good, and I'm currently experimenting the creation of a language server based on it (and your puccini-language-server as a reference) 🙏

The spec just got upgraded a few days ago to 3.17.0 (05/10/2022), we should upgrade the protocol accordingly (if it's not too much effort).

I'm ready to help, still working around your code atm, but totally available 😇

grouville commented 2 years ago

Ok, I checked the changes, I think I can fire a PR by the end of week (if you don't see any complication I might have missed). Could you please assign it to me ?

tliron commented 2 years ago

You are an angel, thank you! Will happily assign to you.

grouville commented 2 years ago

I didn't forget you @tliron, still implementing the language server first before upgrading the protocol (if that's ok with you)

semanticart commented 7 months ago

👋 Hi, folks. Is there anything I can do to help move this forward? I'm a new user to this library and would love to use 3.17-specific types. Thanks!

tliron commented 7 months ago

@semanticart Thank you for volunteering to submit a PR for 3.17 support. :)

redexp commented 4 days ago

Good day everyone

I'm looking on code of protocol_3_17 and as for me you are going hard way. As for me it will be easier to create separated repo with just protocol_3_16 and to fork it as protocol_3_17 (so any bug fixes from 3.16 can be merged to 3.17) and so on protocol_3_18... so any fixes to previous versions could be merged to last one.