Closed slimsag closed 1 year ago
I sure do want it. :)
To my defense, writing this library involved a lot of brainless boilerplate that an AI could probably have done with fewer mistakes. Thanks for catching this one and for submitting a fix!
Also, let me say it's an honor to get a PR from the "zig/mach guy". It's a very sensible language. I dabble in game dev and have a nice little voxel engine I wrote in C (I hate C++). I have been considering a rewrite in Rust, but maybe Zig would make more sense. If you have an inclination to convince me or any reading materials I am wide open.
👋 I work at Sourcegraph and was looking at using your (awesome) library for an experiment, and was encountering some stack overflows (sorry for not providing a test case / reproduction):
It seemed the fix was rather simple as
MarkedStringStruct
was already declared - just not used - to workaround a potential recursiveUnmarshalJSON
operation, so I figured I'd send the fix in case you want it :)