search

tliron / glsp

Language Server Protocol SDK for Go
Apache License 2.0
149 stars 21 forks source link

Fix crash when the request params is null #4

Closed mickael-menu closed 3 years ago

mickael-menu commented 3 years ago

In some cases (e.g. a shutdown event) the request JSON params is null, which was crashing GLSP's handle().

tliron commented 3 years ago

Thank you! I didn't realize that the jsonrpc2 library would allow it to be null...

tliron commented 3 years ago

By the way, do you have a repository with your work using glsp? I'd like to include it in the README as a reference for users.

mickael-menu commented 3 years ago

Yes although the LSP server feature is not yet released, I will release it this week-end or maybe next week: https://github.com/mickael-menu/zk

I've been building a VS Code client extension too https://github.com/mickael-menu/zk-vscode but personally I'm using the LSP server with Neovim and coc.nvim. Some users of zk are using Neovim 0.5 and the new built-in LSP client.

You can find the code using GLSP here