search

tlittenberg / lisacattools

Python module for interacting with example LISA catalogs
GNU General Public License v3.0
15 stars 7 forks source link

Improvement and fixes #15

Closed J-Christophe closed 1 year ago

J-Christophe commented 1 year ago

Hi Tyson,

WARNING : Before merging, please remove the contents of your branch gh-pages - now the tests report and documentation are built automatically when a commit is done.

Here is a couple of improvements and fixes :

(1) : an Astropy function behavior has changed a little bit - I found a bug, I guess : before warp_angle was applied on latitude instead of longitude

J-Christophe commented 1 year ago

Google drive is not the prefect solution to share the files : Too many users have viewed or downloaded this file recently. Please try accessing the file again later. If the file you are trying to access is particularly large or is shared with many people, it may take up to 24 hours to be able to view or download the file. If you still can't access a file after 24 hours, contact your domain administrator. Do you have another way to share the files ?

tlittenberg commented 1 year ago

@J-Christophe do I understand correctly that I should delete the gh-pages branch entirely?

J-Christophe commented 1 year ago

@tlittenberg Two ways : 1/ Either delete it and create a new empty gh-pages branch https://linuxhint.com/create-empty-branch-on-github-using-git-terminal/ 2/ Either, switch on you gh-pages in your terminal and rm -rf . then push (I used that way)

Once you will commit on the main branch, .github/worfkows/deploy.xml will be executed. Note that I could not test the last version of the deploy.xml script because I was not allowed to download the files from google drive (it seems after a certain number of downloads, I needed to wait one or two days and I did not try since). So if the github action failed, just commit this file : That one works and produce this web page : https://j-christophe.github.io/lisacattools/

If the process works, the documenation will be automaticaly built and deployed at each commit.

PS: the current deploy.xml should run the tests and the examples of the documentation for python 3.8,3.9 and 3.10 where as the old one runs the tests and axamples only for python 3.10 PPS : You can check that this deploy.xml is working properly if you click on the "actions" tab to the right of the "pull requests" tab.

tlittenberg commented 1 year ago

I tried your recommendation 2). checked out the gh-pages branch, rm -rf (needed sudo) and then tried to commit. I get the following error:

"pre-commit not found. Did you forget to activate your virtualenv?"

J-Christophe commented 1 year ago

malapert@malapert-HP-ZBook-17-G2:~/Work/lisacattools$ ll .git/hooks/ total 72 drwxrwxr-x 2 malapert malapert 4096 janv. 13 12:42 ./ drwxrwxr-x 9 malapert malapert 4096 janv. 16 02:57 ../ -rwxrwxr-x 1 malapert malapert 478 janv. 12 20:18 applypatch-msg.sample -rwxrwxr-x 1 malapert malapert 896 janv. 12 20:18 commit-msg.sample -rwxrwxr-x 1 malapert malapert 4655 janv. 12 20:18 fsmonitor-watchman.sample lrwxrwxrwx 1 malapert malapert 30 janv. 12 20:24 post-commit -> ../../scripts/post-commit.bash -rwxrwxr-x 1 malapert malapert 189 janv. 12 20:18 post-update.sample -rwxrwxr-x 1 malapert malapert 424 janv. 12 20:18 pre-applypatch.sample -rwxrwxr-x 1 malapert malapert 643 janv. 16 01:25 pre-commit lrwxrwxrwx 1 malapert malapert 29 janv. 13 12:41 pre-commit.legacy -> ../../scripts/pre-commit.bash -rwxrwxr-x 1 malapert malapert 1643 janv. 12 20:18 pre-commit.sample -rwxrwxr-x 1 malapert malapert 416 janv. 12 20:18 pre-merge-commit.sample -rwxrwxr-x 1 malapert malapert 1492 janv. 12 20:18 prepare-commit-msg.sample -rwxrwxr-x 1 malapert malapert 1374 janv. 12 20:18 pre-push.sample -rwxrwxr-x 1 malapert malapert 4898 janv. 12 20:18 pre-rebase.sample -rwxrwxr-x 1 malapert malapert 544 janv. 12 20:18 pre-receive.sample -rwxrwxr-x 1 malapert malapert 2783 janv. 12 20:18 push-to-checkout.sample -rwxrwxr-x 1 malapert malapert 3650 janv. 12 20:18 updat

tlittenberg commented 1 year ago

Are you able to just merge the pull request? I assigned it to you in github

J-Christophe commented 1 year ago

yes, I can do it if you give me right

On Tue, Jan 24, 2023 at 8:54 PM Tyson Littenberg @.***> wrote:

Are you able to just merge the pull request? I assigned it to you in github

— Reply to this email directly, view it on GitHub https://github.com/tlittenberg/lisacattools/pull/15#issuecomment-1402517141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU6DFNLLBBQ4SQJBXLWSV3WUAXOZANCNFSM6AAAAAAT2LXV2M . You are receiving this because you were assigned.Message ID: @.***>