use joi.link to only resolve strictly recursive self-references

tlivings / enjoi

Converts a JSON schema to a Joi schema.

Apache License 2.0

282 stars 57 forks source link

use joi.link to only resolve strictly recursive self-references #112

Closed nlundquist closed 3 years ago

nlundquist commented 3 years ago

... joi.link fails when attempting to resolve to a cousin or uncle node, which is not a scenario we need to handle since that's scenario is not recursive.

nlundquist commented 3 years ago

hey @tlivings could this bugfix get merged? would you like a test to be added?

czlowiek488 commented 3 years ago

Is it gonna be merged? I need this in my project.

czlowiek488 commented 3 years ago

@tlivings Hey, is it something wrong with this PR? People are waiting for it.

tlivings commented 3 years ago

Sorry this fell off my radar. Reviewing now.

tlivings commented 3 years ago

Can you add a test?

thanks.

czlowiek488 commented 3 years ago

@nlundquist

nlundquist commented 3 years ago

just pushed that test, apologies for the delay.