search

tlivings / enjoi

Converts a JSON schema to a Joi schema.
Apache License 2.0
282 stars 57 forks source link

Update needed to support new version of Hapi and Joi #79

Open rmothilal opened 5 years ago

rmothilal commented 5 years ago

Hapi and Joi have had a massive refactor of their libraries https://github.com/hapijs/joi/issues/2037 hapi-openapi relies on this library to validate a swagger. The enjoi library needs an update to use these latest libraries so that hapi-openapi can use the latest version of this

rmothilal commented 4 years ago

@tlivings has there been any progress here? I have been doing a code upgrade on my fork https://github.com/rmothilal/enjoi/tree/feature/make-enjoi-compatible-with-joi-16 I am having issues with the allOf extension as well as the tests for override extensions. Any assistance would be greatly appreciated @JoeScho @tlivings

tlivings commented 4 years ago

Want to submit a PR? I can pull it down and experiment.

rmothilal commented 4 years ago

Hi @tlivings, thanks for the reply, I have created a PR https://github.com/tlivings/enjoi/pull/85 Please let me know what changes you require

JoeScho commented 4 years ago

Hey - poor timing on my behalf 😆 I also created a PR which I think fixes this #84. Please feel free to close it if you decide to merge #85

rmothilal commented 4 years ago

@tlivings Have you managed to review anything in my PR?

tlivings commented 4 years ago

@rmothilal I am reviewing it. Thanks.

svrnwnsch commented 4 years ago

Is this fixed with new version 7.0.0?