tlkenergy / sim-tlk

Roadmap and Issues for sim.TLK cloud based system simulation
2 stars 1 forks source link

Unit Bug: Since Update #29

Closed Walshest closed 1 year ago

Walshest commented 1 year ago

High Priority Hi @PascalPadberg, On some of our models we are getting failed simulations (see attached log) Simulation with id 661 failed.txt

I found found that this is due to the model output/ variable didn't have a unit assigned from Modelica and therefore we manually assigned it. Now it is not allowed to use these manually assigned units. The solution I see: If there is no unit assigned; allows any unit to be displayed on the plot.

image
PascalPadberg commented 1 year ago

That is already implemented as you describe, if there is no unit in the FMU, you can choose from all the available units.

The compressor power has a unit in this FMU: image

Walshest commented 1 year ago

I am getting an error back from a lot of our models: e.g. Error: apps.units.exceptions.UnitsNotCompatible: Origin unit belongs to quantity MoleFraction and target unit to MassFlowRate. Model: TXV_TR6_R404a

image
PascalPadberg commented 1 year ago

Now it works. I had to re-read the model_description of this FMU

Walshest commented 1 year ago

Now it works. I had to re-read the model_description of this FMU

Thanks I confirm this works now, we will have this issue on several other models:

  1. MOPD_ER6
  2. OrificeValveEvaporator
  3. ETS5M_MOPD
PascalPadberg commented 1 year ago

I fixed those, too

Walshest commented 1 year ago

The model still isn't working:

  1. MOPD_ER6 : apps.units.exceptions.UnitsNotCompatible: Origin unit belongs to quantity Time and target unit to MoleFraction.
PascalPadberg commented 1 year ago

The problem with this is that line plots are used with variable "time". This should be done with "timeseries" plots, because the variable "time" is not included in the FMU

PascalPadberg commented 1 year ago

I could change the "line" plot to "timeseries" plot for you. So you don't have to recreate them