tlkenergy / sim-tlk

Roadmap and Issues for sim.TLK cloud based system simulation
2 stars 1 forks source link

pH diagram Improvements #50

Open Walshest opened 10 months ago

Walshest commented 10 months ago

Hi, Two Improvements for the pH Diagrams would be:

1. Simulation Parameter Selects which Ph group to plot:

e.g. I have a parameter "SystemType" which can active which Ph group to show:

(implementation in Django only would be fine)

2. Additional variables in pH states. Like in DaVE

When using the pH diagrams; Temperatue [oC] is missing and we always need to manually calculate it. It would be a major benifit if that can also be shown in the description box like in DaVE.

image

Other variables could also be optionally shown e.g. quality but not a must.

FelixBrandl2 commented 10 months ago

Hi Stefan,

  1. Currently it is not implemented to dynamically hide series in a Plot, but we may add this the current solution would be to create intermediate Variables in the FMU which switch between different statepoint depending on your "SystemType" Parameter and then you only show one Series with this variables.
  2. The Functionality to show Temperature and density for each statepoint is already implemented here are some examples:

image

image

Walshest commented 10 months ago

Thanks, I have just tried out the functionality to show temperature and it doesn't work as expected. The temperature isn't avilable as a variable in the .FMU. Do you maybe have another varient of the StateSensor which has a temperature variable:

image
FelixBrandl2 commented 10 months ago

You need to create a custom statepoint or add additional sensors to include these variables the normal statepoint only has h and p.

Walshest commented 10 months ago

You need to create a custom statepoint or add additional sensors to include these variables the normal statepoint only has h and p.

Thanks for the quick feedback. This worked :D