tlkenergy / sim-tlk

Roadmap and Issues for sim.TLK cloud based system simulation
2 stars 1 forks source link

Improvements of pH diagram #7

Closed Walshest closed 2 years ago

Walshest commented 3 years ago

@pascal mentioned that the pH diagram interface will be improved.

This will be that it will identify the system states and cycles in a more automated way, similar to DaVE tool.

Can you close this when it is finished please, so we know it is implemented?

Walshest commented 2 years ago

Hi @PascalPadberg , What is the status of the pH diagrams? I can see there is some implementation, but it doesn't work.

  1. Cannot save the pH diagram plot: image
  2. Fluid just shows numbers and I believe that should be linked with ENUMs. image

Should the feature be working now?

PascalPadberg commented 2 years ago

It's not working right now, but it will be next week, because we are rolling out an update today and beginning of next week with multiple new features

Walshest commented 2 years ago

It's not working right now, but it will be next week, because we are rolling out an update today and beginning of next week with multiple new features

Great, looking forward to it. It would be great if you can provide a list of the features that will be implemented. :)

PascalPadberg commented 2 years ago

resolved with v2.0.0

Walshest commented 2 years ago

resolved with v2.0.0

Hi @PascalPadberg , I have tested out the pH plots with a simple model and it doesn't work. I am not able to save the pH diagram (no warnings/ errors are given back)

The code for the pH diagrams seems to give an extra statepoint back and this could be the issue?: statePoint is there twice { "name": "state-points", "xyVariableGroupName": "VLE Fluid ID 2", "variables": [ { "name": "statePoint", "xVariable": { "value": "statePoint:h" }, "yVariable": { "value": "statePoint:p" } }, { "name": "statePoint4", "xVariable": { "value": "statePoint4:h" }, "yVariable": { "value": "statePoint4:p" } }, { "name": "statePoint5", "xVariable": { "value": "statePoint5:h" }, "yVariable": { "value": "statePoint5:p" } }, { "name": "statePoint1", "xVariable": { "value": "statePoint1:h" }, "yVariable": { "value": "statePoint1:p" } }, { "name": "statePoint3", "xVariable": { "value": "statePoint3:h" }, "yVariable": { "value": "statePoint3:p" } }, { "name": "statePoint", "xVariable": { "value": "statePoint:h" }, "yVariable": { "value": "statePoint:p" } } ] }

PascalPadberg commented 2 years ago

Hi Stefan, it was another issue. But we just fixed it. Should be online in 5 minutes. Then I will test it as well.

Walshest commented 2 years ago

Additionally there is a limitation that the Fluid is not read from the simulation model when it is being simulated.

image

Walshest commented 2 years ago

There is also a new saving issue which could be causing the saving problem:

image

Sometimes the .FMU is exported without this output/ variable of CPUTime

PascalPadberg commented 2 years ago

Yes, that limitation is due to the fact, that the refrigerant cannot be read from the FMU.

We are going to add the option, that the refrigerant selection can be connected to a parameter. It is already possible, just not in the fmu config interface. So if you need it, I could configure it for you. The problem is, that you need to know the IDs of the fluid in our data base, because strings do not work with FMUs.

PascalPadberg commented 2 years ago

I thought about it during lunch break and I think it is indeed possible to get around the problem with fluid IDs. But I'll have to test it and and it would take some time to implement