search

tlkio / feedback

Feedback on tlk.io
3 stars 0 forks source link

iPhone X support #1

Open simurai opened 6 years ago

simurai commented 6 years ago

The chat UI on an iPhone X needs improvement:

Whenever someone is chatting while I’m typing, or when I go in to @ multiple people, the text box jumps behind the keyboard and not locked. This issue has also occurred since iOS 11.1 on other iPhones.

Second, the notification bar at the top is displaying a black text instead of white text, screenshot provided for reference.

image1

antstorm commented 6 years ago

@simurai have you had experience with iPhone X? I'll try downloading a simulator and figuring out what's wrong with it.

simurai commented 6 years ago

have you had experience with iPhone X?

I wish.. 😉 but still on a 6s. I guess we need to add some padding at the bottom so that "swipping to homescreen bar" and tlk.io's input don't overlap.

Apple added some "safe area" properties that we might can use: https://webkit.org/blog/7929/designing-websites-for-iphone-x/

simurai commented 6 years ago

Re. black status bar at the top. Tested it with the iPhone simulator. It only happens when you save tlk.io as a home screen app. The status bar starts off white, but then turns black (with black text).. even when using a light theme. So not sure why it thinks the background should be black.

bar

antstorm commented 6 years ago

Hmm… that's interesting. I guess it's a default behaviour, because as far as I know on an actual device it will look as if the screen ends there.

Also is there a way to detect that it's running in a "web-app" mode?