search

tlnagy / OMETIFF.jl

I/O operations for OME-TIFF files in Julia
Other
24 stars 7 forks source link

Use proper mapping for OME-XML time units to Unitful time units #32

Closed tlnagy closed 4 years ago

tlnagy commented 5 years ago

Currently, I directly cast the OME-XML time units to Unitful ones:

https://github.com/tlnagy/OMETIFF.jl/blob/9b7a431133624292a5c05cd3b18e366f946b5524/src/parsing.jl#L94-L96

This is really fragile and there should be a proper 1 to 1 mapping between the OME-XML time units (see https://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2016-06/ome_xsd.html#UnitsTime for the possible values) and https://github.com/PainterQubits/Unitful.jl/blob/be0190219e60f9eac5a5b60f1011e942a865aad9/src/pkgdefaults.jl#L246-L247

tlnagy commented 4 years ago

I'm not sure that this is needed any more.