search

tlnagy / OMETIFF.jl

I/O operations for OME-TIFF files in Julia
Other
24 stars 7 forks source link

rearchitect loading abstraction #8

Closed tlnagy closed 7 years ago

tlnagy commented 7 years ago

this is a major redesign of how OME-TIFFs are loaded and should be more robust and extensible than the original approach. OME-TIFFs are now treated as a list of images, each containing a list of files where the data is actually stored. This structure should also be flexible enough to accommodate support for #3.

codecov-io commented 7 years ago

Codecov Report

Merging #8 into master will increase coverage by 2.24%. The diff coverage is 97.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage    91.8%   94.04%   +2.24%     
==========================================
  Files           4        4              
  Lines         122      168      +46     
==========================================
+ Hits          112      158      +46     
  Misses         10       10
Impacted Files Coverage Δ
src/parsing.jl 93.1% <100%> (-0.45%) :arrow_down:
src/utils.jl 86.66% <100%> (+15.23%) :arrow_up:
src/loader.jl 89.74% <97.14%> (-4.01%) :arrow_down:
src/files.jl 97.64% <97.64%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15285c6...ed220d0. Read the comment docs.

tlnagy commented 7 years ago

Looks like it is passes on the latest release, but failing on master due to issues among the dependencies. MacOS builds are stalled so I'm just going to go ahead and merge.