search

tlnagy / OMETIFF.jl

I/O operations for OME-TIFF files in Julia
Other
24 stars 7 forks source link

suspicious ImageShow dependency #83

Closed johnnychen94 closed 3 years ago

johnnychen94 commented 3 years ago

Does this package really need ImageShow? I ask this because OMETIFF sounds like a pure image IO backend.

tlnagy commented 3 years ago

I believe I originally included it for pragmatic reasons because sometimes the display would attempt to dump an enormous image after loading and crash IJulia. I believe this usually happened when it used Colors.jl's show function instead of writing to a PNG and reading it back in like ImageShow. Not sure if that's been fixed.

tlnagy commented 3 years ago

Given that I don't see any ill effects of not having ImageShow in TiffImages, I went ahead and merged.

johnnychen94 commented 3 years ago

That issue was fixed in https://github.com/JuliaGraphics/Colors.jl/pull/346