Closed johnnychen94 closed 3 years ago
Appears that the git submodule isn't being downloaded before the tests?
Yep, it should work now! A new clone needs to follow with git submodule init
so that git submodule update
works and I made the if
statement wrongly.
Merging #88 (8775741) into master (2556424) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 6 6
Lines 345 345
=======================================
Hits 330 330
Misses 15 15
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2556424...8775741. Read the comment docs.
Do you mind bumping the patch version and then I can merge?
Thanks for putting this package on a diet! :sweat_smile:
Okay, let's merge https://github.com/tlnagy/exampletiffs/pull/1 first and I'll update the patch version and the submodule URL together.
Done.
Just a note, that in future PRs with large test image you might need to separate it into two PRs: one for OMETIFF and one for exampletiffs.
That's fine!
That's fine!
In this case, I think this PR is ready to merge.
Thanks for taking the initiative and getting this done 💯
hmmm, since it bumps the version, maybe make a new release?
IMO the VersionVigilante rule is too strong, maybe we should only trigger it when src/
is changed.
That's true. It's overly aggressive, but for projects that have slowed down the PR rate (like this one) it isn't a bad policy to have a release after each PR so that the changes make it out to stable without waiting forever.
hmmm, since it bumps the version, maybe make a new release?
Done
closes #87
I use git submodule feature because it avoids repeated test time data downloading.
Let's see if it works with my fork URL, and if it works, we can merge https://github.com/tlnagy/exampletiffs/pull/1 and then update the URL.
After
git submodule update --remote
:git clone
still downloads the entire git history so it will still be slow unless we ignore the history, e.g.,git clone git@github.com:johnnychen94/OMETIFF.jl.git --branch jc/testimages --depth 1