tloncorp / indigo-react

React components that implement Tlon's design language
MIT License
40 stars 6 forks source link

Tailwind Conversion #119

Open arthyn opened 3 years ago

arthyn commented 3 years ago

At this point the library itself is converted, still need to update docs and make sure the distribution setup is correct.

General principles

Issues and areas of improvement

addressed

not addressed

Todos

now

later

g-a-v-i-n commented 3 years ago

Huge

arthyn commented 3 years ago

Something I realized after I did all this that I might change, the true red/blue/green/yellow should always be the same number aka 400. You can see here that red and green are missing what would be "300" https://www.figma.com/file/5RhWFWqRFSeddpD6X0Xt6C/indigo-colors?node-id=0%3A1 so I'll probably shift those.

liam-fitzgerald commented 3 years ago

Re the themeing stuff, consider maybe using CSS vars perhaps?

arthyn commented 3 years ago

Good call, found a library which will do the vars and also has the ability to make preset themes if we wanted to that later. Required a little messing around, but looks like it works.

Pretty much all the the properties that people may want to change should be in there with the exception of font-size which would require a patch in the library to support TW 2.0 use of font-size + line-height object.