search

tloncorp / indigo-react

React components that implement Tlon's design language
MIT License
40 stars 6 forks source link

how should we do grids? #12

Closed jyng closed 5 years ago

jyng commented 5 years ago
Screen Shot 2019-08-30 at 3 05 02 PM

Right now i'm using flexbox and defining flex-basis on each child-item (Don't really see this scaling well) I see that you're using css grid in spacing.js. What do you recommend? I'm more used to the way basscss does this or even bootstrap.

jyng commented 5 years ago

I keep finding myself trying to reach for something like container on the parent and col-8 or col-6-sm on the child. The way I'm used to it being done is to define these CSS classes. Should these be included in the primitives then?

jyng commented 5 years ago

Issue has been resolved to rely on flexbox and using percentage widths