indigo-dark base black too dark?

matildepark commented 4 years ago

testing out pulling off the bandages and it just feels like the theme is mixed odd, will supply a working branch once my chat PR is pushed in

matildepark commented 4 years ago

OK this lives at mp/landscape/indigo-themes for inspection

tacryt-socryp commented 4 years ago

Wow this looks incredible

urcades commented 4 years ago

The first reaction I have to this is that the pure black (black100) background is quite an extreme look: This approach makes sense when one takes into consideration OLED screens and the like (pure black interfaces are battery-saving), but I'd be interested in us seeing a bump down in the black used, aka black90.

This said, in many applications/apps, you often see preferences allowing a 'day', 'night (lower contrast)', and 'oled (higher contrast)' setting. This could be a nice affordance for our mobile users.

The greater (and actual/non-preference-based) issue here is obviously our borders surrounding interactive elements being destroyed/made invisible somehow. It'd be good to retain these for our dark theme, so interactive elements are more obvious.

g-a-v-i-n commented 4 years ago

This is the exact purpose of themes.
This change should be scoped to the theme, not the color assignment on the component.
I think the black is too dark. In the theme, I would set the 'black' value to #1A1A1A, which is black90 mixed on a white bg.

matildepark commented 4 years ago

I mean ... this is about the theme, not the colour assignment? I'm confused. All I did was swap out the themes in our theme folder for the imported themes.

matildepark commented 4 years ago

Specifically https://github.com/urbit/urbit/commit/2005604c9d06abf10396fe4210f25ba1a4309125

g-a-v-i-n commented 4 years ago

Oh I see. I would just PR indigo-dark with black changed to #1A1A1A.

g-a-v-i-n commented 4 years ago

Or I can just do it now

tloncorp / indigo-react

indigo-dark base black too dark? #83