search

tloncorp / indigo-react

React components that implement Tlon's design language
MIT License
40 stars 6 forks source link

request: decide on which "gray value" is the de-facto description of lightgray and washedgray #98

Closed urcades closed 3 years ago

urcades commented 3 years ago

Howdy, dropping in here to mention that the lightgray/black20 and washedgray/black04 we use in Figma is currently not reflected in indigo-react, which is visible via the current developer testnet (check the red annotations):

Screen Shot 2021-03-30 at 3 29 16 AM

As it stands, it appears that we define lightgray in "indigo-react" as black30 and washedgray as black05 in indigo-light:

https://github.com/urbit/indigo-light/blob/master/index.ts#L94-L95

This is all to say, I really do love the way black20 and black04 appear onscreen. The difference is very subtle, but there is a 'starkness' to the currently-defined approach in indigo-react that causes the interface to appear overly-stroked or line-heavy:

indigo-react:

Screen Shot 2021-03-30 at 3 25 59 AM

figma indigo:

Screen Shot 2021-03-30 at 3 26 23 AM
urcades commented 3 years ago

The summation of my perspective here is that we've been using figma's version of indigo's color rules, and they look very good, and support (as far as I'm aware) the contrast necessary for properly distinguishing elements on-screen.

If this is all correct, we should move indigo-react to use the black/white20 and black/white04 definition of light and washed grays.

g-a-v-i-n commented 3 years ago

Yeah, this is annoying I will fix

g-a-v-i-n commented 3 years ago

Closing because I merged your PR