tlongstretch / freeserf-with-AI-plus

THIS PROJECT WAS MOVED TO 'Forkserf', GO THERE INSTEAD
https://github.com/forkserf/forkserf
GNU General Public License v3.0
1 stars 0 forks source link

AIPlus feature - serfs in boats bug affecting serf pathfinding #43

Closed tlongstretch closed 3 years ago

tlongstretch commented 3 years ago

I believe i've introduced a bug where a FlagSearch for a serf won't consider a path to be valid unless it has a transporter. This is wrong, it should only reject WATER ROADS that do not have a transporter (sailor).

tlongstretch commented 3 years ago

This is fixed now. I also rewrote the whole Flagsearch::execute function to be easier to understand. It uses a mess of double-negative bool conditions and is really hard to understand.