CRAN submission - Githubissues

lorenzwalthert commented 3 years ago

Hi there, cool package. Are there plans to submit this to CRAN? I am also sitting in Zurich btw :-) We depend on this in production and I'd sleep better if it was on CRAN than GitHub only :smile: . I might also be able help you with some R CMD Check things and the submission process if needed.

tlorusso commented 3 years ago

Hi @lorenzwalthert, nice to hear that the package is of use. I did originally intend to submit it after extending its functionalities. I've added support for a further API-module to the dev-version, which allows to calculate traveltime between two coordinates. However then i didn't find the time to test if everything works as intended (and now it has been quite i while since i touched anything). Also, that the API is not entirely 'open' lowered the incentives to invest time in it a bit for me. However, i would still consider submitting it. And it would certainly help if you'd be interested in taking over some testing or even would consider co-maintaining it.

Did you run some R CMD (or even extended rhub-checks) with it yet?

lorenzwalthert commented 3 years ago

I'd suggest to:

add GitHub Actions with usethis::use_github_action_check_standard()
make R cmd check pass
add unit tests. Not sure if we can obtain a API key from them for testing. I think the 10k limit mentioned in the README is no longer true.
make sure README is up to date with usage limits.
Try to submit to CRAN.

I can start filing PRs if you agree with this approach.

tlorusso commented 3 years ago

Sounds good to me. Indeed, they seem to have modified their pricing schemes. I can reach out to them to ask regarding an API- Key for testing purpouses. I guess otherwise the only thing we could cover via unit tests would be the response one gets without a key.

Feel free to start working on the PRs.

Are you interested in the isochrones only or would the distance matrix module (https://traveltime.com/docs/api/reference/distance-matrix) also be of interest to you? If the latter could be useful, you could have a look at the dev branch and start from there, not sure if the respective traveltime_filter function is mature enough for a CRAN-version tough. Otherwise just ignore the dev branch and work with whats in the main branch.

tlorusso commented 3 years ago

hi @lorenzwalthert, i've got some news:

the API plans have changed. Users can get free access for 10 days (free access for longer periods is granted on request, however i don't have detailed information on the criteria yet).
we could get a token for testing (limited nr. of requests). I'd have to ask again for more details tough.

If you're still interested in bringing the package to CRAN let me know.

lorenzwalthert commented 3 years ago

Hi @tlorusso. I was using this package at work and now I quit, so for me there is no incentive to work on that anymore and I already have too many other open-source things that are time consuming. Also there is no one at work at the moment who uses this anymore. For that reason I won't contribute anything here anymore. Sorry.

arthurgailes commented 3 years ago

Hi @tlorusso, I'd be interested in helping out, but don't know how far you've gotten in working on it or getting an API key.

tlorusso commented 3 years ago

HI @arthurgailes - thanks for your PR and for your interest in contributing. I haven't worked on it since... at the moment i lack the time to contribute to bring it to CRAN. However, anyone who'd like to take this over is free to do so :)

arthurgailes commented 3 years ago

OK. Do you mind if I fork your repo and go from there?

Sincerely,

Arthur W. Gailes

On Fri, Aug 20, 2021 at 11:05 AM Thomas Lo Russo @.***> wrote:

HI @arthurgailes https://github.com/arthurgailes - thanks for your PR and for your interest in contributing. I haven't worked on it since... at the moment i lack the time to contribute to bring it to CRAN. However, anyone who'd like to take this over is free to do so :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlorusso/traveltime/issues/5#issuecomment-902759377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TEIOYHOC5EXUC3PKTO6LT5ZVLBANCNFSM4U7L3TSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

tlorusso commented 3 years ago

OK. Do you mind if I fork your repo and go from there? Sincerely, Arthur W. Gailes … On Fri, Aug 20, 2021 at 11:05 AM Thomas Lo Russo @.***> wrote: HI @arthurgailes https://github.com/arthurgailes - thanks for your PR and for your interest in contributing. I haven't worked on it since... at the moment i lack the time to contribute to bring it to CRAN. However, anyone who'd like to take this over is free to do so :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7TEIOYHOC5EXUC3PKTO6LT5ZVLBANCNFSM4U7L3TSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Go for it ;)

Donatas-L commented 3 years ago

@arthurgailes @tlorusso an official SDK for R has been released, it might be of any help for you guys see: https://github.com/tlorusso/traveltime/issues/8

tlorusso / traveltime

CRAN submission #5