search

tlpss / keypoint-detection

2D keypoint detection with Pytorch Lightning and wandb
MIT License
70 stars 9 forks source link

Added a MobileNetV3 backend #24

Closed lucasvandijck closed 1 year ago

lucasvandijck commented 1 year ago

Based on ConvNeXt backend code, this PR adds the 3.4M param MobileNetV3 backend.

Again, I did not write test functions.

tlpss commented 1 year ago

@lucasvandijck , thanks for adding mobilenet. Could you maybe reuse the upsampling block from the convnext to avoid code duplication?

Again, I did not write test functions.

That's okay. All registered backbones get tested here

lucasvandijck commented 1 year ago

@lucasvandijck , thanks for adding mobilenet. Could you maybe reuse the upsampling block from the convnext to avoid code duplication?

Again, I did not write test functions.

That's okay. All registered backbones get tested here

This should be fixed. I didn't like the inter-backend dependencies, hence why I re-implemented it, but this should work fine as well.

tlpss commented 1 year ago

I didn't like the inter-backend dependencies, hence why I re-implemented it, but this should work fine as well.

yeah the proper way would be to refactor that upsamplingblock, but this is still bettern than duplicating code :+1: