tlrobinson / narwhal

[DEPRECATED] A JavaScript standard library, package manager, and more.
http://narwhaljs.org/
372 stars 16 forks source link

Break Dependency Cycles in Package Analysis #16

Open kriskowal opened 15 years ago

kriskowal commented 15 years ago

lib/packages.js performs a topological sort of all installed packages. Presently, an error occurs if there is a cyclic dependency in any subgraph, for example, if "jack-servlet" and "appengine-java-sdk" are erroneously mutually dependent. Detect this case in lib/packages.json and during tusk create-catalog to avoid distributing faulty package catalogs.

kriskowal commented 15 years ago

This is fixed in my refactor branch, but we need to prepare for the pull with release notes to engine developers.