custom clientNamed groups for parimitha

tls-attacker / TLS-Attacker

TLS-Attacker is a Java-based framework for analyzing TLS libraries. It can be used to manually test TLS clients and servers or as as a software library for more advanced tools.

Apache License 2.0

789 stars 136 forks source link

custom clientNamed groups for parimitha #113

Closed ghost closed 3 years ago

ghost commented 3 years ago

Added support for customClientNamedGroups

NDS-JENKINS commented 3 years ago

Can one of the admins verify this patch?

ic0ns commented 3 years ago

Hey, can you explain the reasoning behind this patch? As far as I can tell this is just an addition to the config constructor. Why wouldn't the user just add the Groups he wants in the keyshare extension to the defaultClientSupportedNamedGroups List? If you want it to differentiate you could just change the keyshares after the creation of the extension.

ghost commented 3 years ago

@ic0ns we verified it's not needed. thanks