search

tls-attacker / TLS-Attacker

TLS-Attacker is a Java-based framework for analyzing TLS libraries. It can be used to manually test TLS clients and servers or as as a software library for more advanced tools.
Apache License 2.0
789 stars 136 forks source link

Could de.rub.nds.tlsattacker:Attacks:3.6.0 drop off redundant dependencies to loose weight? #116

Closed Celebrate-future closed 3 years ago

Celebrate-future commented 3 years ago

@JonSnowWhite Hi, I am a user of project de.rub.nds.tlsattacker:Attacks:3.6.0. I found that its pom file introduced 47 dependencies. However, among them, 5 libraries (10%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for this project. This PR helps de.rub.nds.tlsattacker:Attacks:3.6.0 lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

NDS-JENKINS commented 3 years ago

Can one of the admins verify this patch?

ic0ns commented 3 years ago

Without having tried it - I vaguely remember that you need these dependencies if you are building TLS-Attacker with something newer than Java 8.