search

tls-attacker / TLS-Attacker

TLS-Attacker is a Java-based framework for analyzing TLS libraries. It can be used to manually test TLS clients and servers or as as a software library for more advanced tools.
Apache License 2.0
778 stars 135 forks source link

Add pre-commit support #124

Closed Holzhaus closed 1 year ago

Holzhaus commented 2 years ago

This adds support for pre-commit hooks that ensure that the code passes some basic checks.

The setup is pretty easy and only has to be done once:

$ cd path/to/repo
$ pre-commit install

Afterwards, these checks run before every commit (i.e. each time when git commit is executed).

These checks can also be used for CI, so I added a GitHub actions workflow that checks new commits and pull requests automatically. Here's what such a workflow run looks like: https://github.com/Holzhaus/TLS-Attacker/runs/5157119380?check_suite_focus=true#step:4:70i

To make sure that all checks pass, this PR fixes a bunch of whitespace issues (missing newline at EOF, trailing whitespace) and typos (found using codespell).

NDS-JENKINS commented 2 years ago

Can one of the admins verify this patch?

Holzhaus commented 1 year ago

Apparently not desired, closing this.