search

tls-attacker / TLS-Attacker

TLS-Attacker is a Java-based framework for analyzing TLS libraries. It can be used to manually test TLS clients and servers or as as a software library for more advanced tools.
Apache License 2.0
789 stars 136 forks source link

-executor_type THREADED_SERVER is not listening on actual host ip instead it is on loop back address only #170

Closed sajualways closed 1 week ago

sajualways commented 4 months ago

java -jar TLS-Server.jar -port 4433 -version TLS13 -executor_type THREADED_SERVER 09:34:23 [main] INFO : ThreadedServerWorkflowExecutor - Initializing server connection end at port 4433 09:34:23 [main] INFO : ThreadedServerWorkflowExecutor - Listening on localhost/127.0.0.1:4433... 09:34:23 [main] INFO : ThreadedServerWorkflowExecutor - --- use SIGINT to shutdown ---

is it a bug or design issue ?

with -executor_type DEFAULT it listens on actual host server ip

ic0ns commented 4 months ago

Hey, this is an unintentional inconsistency between the executors. See here:

https://github.com/tls-attacker/TLS-Attacker/blob/5fe4faf6e06e4422c20b01c3f756c7bc7cf1d0b8/TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/workflow/ThreadedServerWorkflowExecutor.java#L50-L64

It's also more or less just an example on how to do something like this and not necessarily supposed to be used as is.

See: https://github.com/tls-attacker/TLS-Attacker/blob/5fe4faf6e06e4422c20b01c3f756c7bc7cf1d0b8/TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/workflow/ThreadedServerWorkflowExecutor.java#L27-L31