search

tlsfuzzer / python-ecdsa

pure-python ECDSA signature/verification and ECDH key agreement
Other
914 stars 315 forks source link

drop six #294

Closed xiaoge1001 closed 2 years ago

xiaoge1001 commented 2 years ago

do it. https://github.com/tlsfuzzer/python-ecdsa/issues/293

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 2f36ee92e7a87d2ba1dac96f4da8f721eec8a412 into 6c201909e00b7ec56137b25c36ae1acc6d82aeba - view on LGTM.com

new alerts:

tomato42 commented 2 years ago

Sorry, but we don't plan dropping python2 support any time soon.

a-detiste commented 9 months ago

@xiaoge1001 thanks for your patch, it has been included on Debian

https://wiki.debian.org/Python3-six-removal

a-detiste commented 9 months ago

Actualy, six is not needed for b("literal"), b"literal"also works on Python2; these lines could already be now merged.

tomato42 commented 9 months ago

yes change to b'literal' is definitely something we can do (and you can see, happens in new code), but there are things like int_types that are still needed for py2 compatibility.

a-detiste commented 9 months ago

Yes yes... I'm almost done withj my pr "All those moments will be lost in time, like tears in rain."

a-detiste commented 9 months ago

Reducing the diff of 80%~90% would make life of downstreams easier.