tlsfuzzer / python-ecdsa

pure-python ECDSA signature/verification and ECDH key agreement
Other
914 stars 315 forks source link

remove usage of six.b("literal") #329

Closed a-detiste closed 9 months ago

a-detiste commented 9 months ago

as a side effect the program would maybe run faster

a-detiste commented 9 months ago

I think black makes some code better, some code worse.

I don't like it personally.

BAD:

             y_qB=int(
-                "990C57520812BE512641E47034832106BC7D3E8DD0E4C7F1136D70065"
-                "47CEC6A",
+                "990C57520812BE512641E47034832106BC7D3E8DD0E4C7F1136D70065" "47CEC6A",
                 16,
             ),
             x_Z=int(
-                "89AFC39D41D3B327814B80940B042590F96556EC91E6AE7939BCE31F3A"
-                "18BF2B",
+                "89AFC39D41D3B327814B80940B042590F96556EC91E6AE7939BCE31F3A" "18BF2B",
                 16,
             ),
             y_Z=int(
-                "49C27868F4ECA2179BFD7D59B1E3BF34C1DBDE61AE12931648F43E5963"
-                "2504DE",
+                "49C27868F4ECA2179BFD7D59B1E3BF34C1DBDE61AE12931648F43E5963" "2504DE",
                 16,
             ),

GOOD:

-            x_Z=int(
-                "312DFD98783F9FB77B9704945A73BEB6DCCBE3B65D0F967DCAB574EB", 16
-            ),
-            y_Z=int(
-                "6F800811D64114B1C48C621AB3357CF93F496E4238696A2A012B3C98", 16
-            ),
+            dA=int("7C4B7A2C8A4BAD1FBB7D79CC0955DB7C6A4660CA64CC4778159B495E", 16),
+            x_qA=int("B104A67A6F6E85E14EC1825E1539E8ECDBBF584922367DD88C6BDCF2", 16),
+            y_qA=int("46D782E7FDB5F60CD8404301AC5949C58EDB26BC68BA07695B750A94", 16),
+            dB=int("63976D4AAE6CD0F6DD18DEFEF55D96569D0507C03E74D6486FFA28FB", 16),
         )
a-detiste commented 9 months ago

(I had also fixed 2 duplicates of sys that pyflakes complained about)

tomato42 commented 9 months ago

change those lines so that they're not two separate strings?

change from ...F1136D70065" "47CEC6A", to ...F1136D7006547CEC6A",?

tomato42 commented 9 months ago

use tox -e codeformat to reformat according to project's black configuration, we don't use default black config

tomato42 commented 9 months ago

Please rebase your PR on top of current master branch, then force push to the same branch as this PR is using.

Do not merge the master branch to this branch to update it.

tomato42 commented 9 months ago

looks good, thanks!

a-detiste commented 9 months ago

thank you