search

tlsfuzzer / tlslite-ng

TLS implementation in pure python, focused on interoperability testing
Other
234 stars 80 forks source link

Type Hints #473

Open povilasb opened 3 years ago

povilasb commented 3 years ago

Hey folks,

I had a successful use of tlslite-ng, but having type hints would definitely improve coding experience given language server is enabled.

  1. would you be willing to accept type hint PRs?
  2. Are you still considering Python 2 support for future releases?
tomato42 commented 3 years ago

I've got no problem with type hints if they are implemented as comments. Python 2 support is still very much a priority. The primary deployment platform for us is RHEL, so as long as there are supported versions of RHEL that ship with Python 2 as the natively supported version, tlslite-ng will need to support Python 2 (CI running on CentOS 6 is no accident :smile: ).

povilasb commented 3 years ago

Roger. Will try to add some type hints as I use the library ;)