Minor editorial issues and fixing metadata to stop annoying make errors.

tlswg / draft-ietf-tls-esni

TLS Encrypted Client Hello

https://tlswg.github.io/draft-ietf-tls-esni/#go.draft-ietf-tls-esni.html

Other

229 stars 56 forks source link

Minor editorial issues and fixing metadata to stop annoying make errors. #589

Closed taddhar closed 7 months ago

taddhar commented 10 months ago

Fixing some minor editorial issues, e.g. the abuse of 'first' with no 'then' or 'second' or 'secondly' etc.
In X.509 don't forget the dot
Boring make errors because of metadata issues

About the latter, I get the warning that I don't know how to fix

warnings.warn(
*** attributes left {"authors"=>[{"ins"=>"K. Bhargavan", "org"=>"Inria"}, {"ins"=>"V. Cheval", "org"=>"Inria"}, {"ins"=>"C. Wood", "org"=>"Cloudflare"}]}!

ekr commented 10 months ago

There's nothing wrong with "First"..."later". I don't think we should change these.

ekr commented 7 months ago

I have fixed the metadata issue in #599.

As noted above, I don't believe the proposed text changes are necessary/right and as they are within editorial discretion, I am closing the PR unmerged.