search

tlubitz / SBtab

SBtab - Table format for Systems Biology:
www.sbtab.net
MIT License
6 stars 8 forks source link

Fix: if SBtab Table is added to SBtabDocument, do not rely on it havi… #104

Closed tlubitz closed 3 years ago

tlubitz commented 3 years ago

…ng a filename

eladnoor commented 3 years ago

Wouldn't it be safer to set .filename to None if it is not provided explicitly?

tlubitz commented 3 years ago

You mean in the SBtabTable class, right?

eladnoor commented 3 years ago

Yes, for the SBtabDocument this is already the case: https://github.com/tlubitz/SBtab/blob/00c63099f86493bd9fb204f7727e3690add2217a/python/SBtab.py#L956

tlubitz commented 3 years ago

Okay, I changed this. Have a look, please