search

tlubitz / SBtab

SBtab - Table format for Systems Biology:
www.sbtab.net
MIT License
6 stars 8 forks source link

Writing a new SBtabDocument #56

Closed eladnoor closed 6 years ago

eladnoor commented 6 years ago

The option of creating an SBtabDocument from individual existing SBtabTables requires giving them unique filenames (even though these names are not used anywhere). Also, the function SBtabDocument.write() doesn't work unless one defines the SBtabDocument.delimiter attribute manually - which is probably a bug.

tlubitz commented 6 years ago

Fixed

eladnoor commented 6 years ago

I think the first issue is still not solved. In line 764 in SBtab.py, this check is performed:

if sbtab.filename in self.sbtab_filenames:
            raise SBtabError('The SBtab could not be added it has the '
                            'same table name as an existing SBtab:'
                            ' %s.' % (sbtab.filename))
return

Perhaps the intention was to check for duplicates in the table_name rather of the filename?

tlubitz commented 6 years ago

I am really not entirely sure why this check existed; I assume it belonged to the integrity of the web interface, but is not required anymore. I removed the check.