search

tlubitz / SBtab

SBtab - Table format for Systems Biology:
www.sbtab.net
MIT License
6 stars 8 forks source link

fixing issue #81: from_data_frame causes errors in header row #82

Closed eladnoor closed 4 years ago

eladnoor commented 4 years ago

I think I found the reason for the bug. from_data_frame() created a few attribute fields with empty strings (double quotes '') but later the _get_header_row() function converts them to single quotes and that messes up things when printing the SBtab. I simply removed these fields from the header when they are empty. However, fixing _get_header_row() could also be a good idea regardless.

tlubitz commented 4 years ago

Hi Elad,

I cannot precisely point out your alterations, because in this case the git diff is not working well: it basically tells me that you removed the whole of SBtab.py and inserted another whole of SBtab.py. This is not a helpful diff, but it's not your fault obviously. But since I trust your expertise, I simply merge the pull request blindly. ;)

Have a good weekend, Timo

eladnoor commented 4 years ago

I only made a very small change to from_data_frame(). I think the diff might not be working because of different OS standards for line endings (I use linux).

tlubitz commented 4 years ago

Yes, by some reason the diff didn't work, but I don't think it was because of the OS. I am using linux as well. Who knows...