search

tlubitz / SBtab

SBtab - Table format for Systems Biology:
www.sbtab.net
MIT License
6 stars 8 forks source link

Feature/new constructor #90

Closed tlubitz closed 4 years ago

tlubitz commented 4 years ago

Hi @eladnoor

I changed the constructor of SBtabTable and SBtabDocument. The new construction of objects is documented in the README of SBtab/python/

But basically it now works rather like this:

sbtab = SBtab.SBtabTable() sbtab.set_filename('filename') sbtab.add_sbtab_string(sbtab_string)

...so that no initial parameters are required anymore and empty objects can be built.

Please be aware that I only changed this in the commandline version to be found in SBtab/python/SBtab.py, and not in the pip installer or the online interface or whatnot, yet.

It would be cool if you could have a look at your panda function SBtabTable.fromDataFrame(), whether you can simplify that one now. I know you were struggling with all the mandatory parameters. And feedback is welcome on the overall move (sorry, I wanted to assign you as reviewer for the pull request, but forgot; would you be willing to act as reviewer in the future? There are going to be a bunch of PRs soon in this repo).

Best Timo

eladnoor commented 4 years ago

Hi @timolubitz ,

This is a very welcome change, I'll be happy to test it (probably only next week, though) and maybe rewrite the fromDataFrame() function. And also being a reviewer for future PRs is a great idea.

Best, Elad

tlubitz commented 4 years ago

Cool, then I'll maybe send some PRs into your direction next week.

Cheers Timo

Am Do., 16. Juli 2020 um 11:44 Uhr schrieb Elad Noor < notifications@github.com>:

Hi @timolubitz https://github.com/timolubitz ,

This is a very welcome change, I'll be happy to test it (probably only next week, though) and maybe rewrite the fromDataFrame() function. And also being a reviewer for future PRs is a great idea.

Best, Elad

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tlubitz/SBtab/pull/90#issuecomment-659301340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPUCF4INQVEIVTVCXNQ35DR33DZPANCNFSM4O2QS54A .

eladnoor commented 4 years ago

Hi,

I rewrote the from_data_frame() function, and also tested it with my code, so far it seems to work. I pushed the changes to the branch so I think you can just merge it again if you think this is good enough.

tlubitz commented 4 years ago

Thanks, Elad,

I merged this into the master!

Best Timo

Am Di., 21. Juli 2020 um 11:52 Uhr schrieb Elad Noor < notifications@github.com>:

Hi,

I rewrote the from_data_frame() function, and also tested it with my code, so far it seems to work. I pushed the changes to the branch https://github.com/tlubitz/SBtab/tree/feature/new_constructor so I think you can just merge it again if you think this is good enough.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tlubitz/SBtab/pull/90#issuecomment-661757680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGPUCF2GUKII3HERMTPXWXDR4VQPLANCNFSM4O2QS54A .