Update formula_hal9001.R

tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso

https://tlverse.org/hal9001

GNU General Public License v3.0

49 stars 15 forks source link

Closed Larsvanderlaan closed 1 year ago

Larsvanderlaan commented 2 years ago

fixed formula bug that generated wrong basis functions

nhejazi commented 2 years ago

Thanks @Larsvanderlaan -- please run make check or devtools::check() locally to make sure the checks are passing. Currently, I'm seeing a possibly unexported (or now deprecated) function, https://github.com/tlverse/hal9001/runs/6714457658?check_suite_focus=true#step:8:23

nhejazi commented 2 years ago

thanks for working on this @Larsvanderlaan --- once you're ready for this PR to be merged, let me know when/if a review might be helpful

Larsvanderlaan commented 1 year ago

Hi Nima, This PR is ready to be merged. Thank you for your help!