tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso
https://tlverse.org/hal9001
GNU General Public License v3.0
49 stars 15 forks source link

Fix quantizer (minor change in how num_knots is used) #106

Closed Larsvanderlaan closed 1 year ago

Larsvanderlaan commented 1 year ago

Minor change.

Previously, data is discretized into quantiles using num_knots and the default quantile() function. This leads to knot points that are outside observed data points.

I changed it to quantile(type = 1), so that quantiles correspond with observed data points. This generates knot points that better respects the original data.