tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso
https://tlverse.org/hal9001
GNU General Public License v3.0
49 stars 15 forks source link

Update make_basis.R #107

Closed Larsvanderlaan closed 1 year ago

Larsvanderlaan commented 1 year ago

Minor change

When using num_knots to bin data into quantiles, default quantile() function was used. This leads to knot points that may not be observed in data.

Now changes to quantile(type = 1), so that all knots are data points.