search

tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso
https://tlverse.org/hal9001
GNU General Public License v3.0
49 stars 15 forks source link

Update needed ahead of Matrix 1.6-2 release #109

Closed jaganmn closed 11 months ago

jaganmn commented 1 year ago

I sent two e-mails to maintainer("hal9001"), on Sep 15 and Oct 7, but did not receive a response. Is GitHub preferred? The gist is that hal9001 fails its checks under forthcoming version 1.6-2 of Matrix. Matrix 1.6-2 is due to be released in November, so a patched version of hal9001 should be submitted to CRAN "soon" to avoid unnecessary archival. The relevant part of the first e-mail is pasted below.

Matrix 1.6-2 is more strict about conformation of x and y in crossprod(x=<vector>, y=<Matrix>) and tcrossprod(x=<Matrix>, y=<vector>), throwing an error in exactly those cases where base R would throw an error if the Matrix were replaced with a traditional matrix. Your packages seem to have relied on the old base-incompatible behaviour, as they now fail with errors "non-conformable arguments" tracing back to crossprod or tcrossprod calls.

Please revise your packages and test that they pass their checks under the latest Matrix-devel, which you can install with

install.packages("Matrix", repos = "http://R-Forge.R-project.org")

IIRC only minimal changes are required. Do let me know if you are unsure how to adjust your code. Then I can investigate and try to provide a patch.

jaganmn commented 1 year ago

We will be submitting Matrix 1.6-2 as early as Nov 3, at which point you may receive a notice from CRAN.

jaganmn commented 11 months ago

I see that the problems have been fixed. Thanks!