search

tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso
https://tlverse.org/hal9001
GNU General Public License v3.0
49 stars 15 forks source link

should replace `ml_hal_fit` with `squashed` right? #28

Closed wilsoncai1992 closed 4 years ago

wilsoncai1992 commented 6 years ago

https://github.com/jeremyrcoyle/hal9001/blob/9ab56bb964dbeda31641bc4b0c5380cad3613434/tests/testthat/test-hal.R#L48-L54

nhejazi commented 6 years ago

Thanks for pointing this out. Yes, it appears that ml_hal_fit should be replaced by squashed in lines 48 and 54 of that unit test script.

nhejazi commented 4 years ago

Fixed at some point in the past.