search

tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso
https://tlverse.org/hal9001
GNU General Public License v3.0
49 stars 15 forks source link

Competing work #70

Closed daviddewhurst closed 4 years ago

daviddewhurst commented 4 years ago

The paper does not talk about competing work at all. If this paper is the first that has been written on software implementation of HAL, this should be clearly stated and then my concern about this will be ameliorated. Otherwise, the authors should more clearly highlight previous implementation of HAL. I see the van der Laan and Dudoit paper series, but it is unclear if these papers are the only prior work, if they address the same questions as this paper, etc.

nhejazi commented 4 years ago

Thank you for raising this question. This is indeed the first software implementation of HAL. The series of papers by van der Laan and Dudoit predates HAL significantly; however, we will amend the paper to additionally cite https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5662030/ and the deprecated/unmaintained package https://github.com/benkeser/halplus

daviddewhurst commented 4 years ago

Great, this removes any concern I had about this.

nhejazi commented 4 years ago

Great, thanks for quickly resolving this. The background I mentioned (along with a few touch-ups to the paper) were added in 67bc25d.