`summary` for higher-order fits, argument changes, updates to `formula_hal` + `fit_hal`

rachaelvp commented 3 years ago

Updated documentation for formula_hal, fit_hal and predict; and added fit_control and formula_control lists for arguments. Moved much of the text to details sections, and shortened the argument descriptions.
Updated summary to support higher-order HAL fit interpretations.
Added checks to fit_hal for missingness and dimensionality correspondence between X, Y, and X_unpenalized. These checks lead to quickly-produced errors, opposed to enumerating the basis list and then letting glmnet error on something trivial like this.
Modified formula interface in fit_hal, so formula is now provided directly to fit_hal and formula_hal is run within fit_hal. Due to these changes, it no longer made sense for formula_hal to accept data, so it now takes as input X. Also, the formula_fit_hal function was removed as it is no longer needed.

NOTE: test-sl will fail due to the updated argument formatting in fit_hal

rachaelvp commented 3 years ago

@Larsvanderlaan test-formula is passing, but just to be sure, could you please check that I updated formula_hal correctly?

Larsvanderlaan commented 3 years ago

Hi Rachael, this looks fantastic! I made some minor changes (correcting a bug with offset that I caused at some point).

tlverse / hal9001