Minor change to binning function

tlverse / hal9001

🤠 📿 The Highly Adaptive Lasso

https://tlverse.org/hal9001

GNU General Public License v3.0

49 stars 15 forks source link

Minor change to binning function #91

Closed Larsvanderlaan closed 3 years ago

Larsvanderlaan commented 3 years ago

Minor change to how binning is performed when num_knots = 1. Now ensures that minimal knot is chosen when num_knots = 1 so that HAL agrees with main term glmnet when smoothness_orders=1 and num_knots=1.

Larsvanderlaan commented 3 years ago

Where does appveyor grab my GitHub token from?

Larsvanderlaan commented 3 years ago

https://github.com/USGS-R/mda.streams/issues/208

Larsvanderlaan commented 3 years ago

Hi @nhejazi, Yes, this is ready to merge. Thank you. Best, Lars